Skip to content

Use React data-view for Kafka clusters table#2539

Merged
MikeEdgar merged 3 commits into
streamshub:mainfrom
MikeEdgar:data-view-research
May 27, 2026
Merged

Use React data-view for Kafka clusters table#2539
MikeEdgar merged 3 commits into
streamshub:mainfrom
MikeEdgar:data-view-research

Conversation

@MikeEdgar

@MikeEdgar MikeEdgar commented Apr 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

For #2501

Subsequent changes will be coming to migrate all tables to use the new component.

@MikeEdgar MikeEdgar force-pushed the data-view-research branch 6 times, most recently from 817819b to cc7e9d4 Compare May 7, 2026 14:40
@MikeEdgar MikeEdgar added this to the 0.13.0 milestone May 7, 2026
@MikeEdgar MikeEdgar force-pushed the data-view-research branch 3 times, most recently from c66f136 to 5f2c265 Compare May 11, 2026 12:19
@MikeEdgar MikeEdgar changed the title Experiment with React data-view for Kafka clusters table Use React data-view for Kafka clusters table May 11, 2026
@MikeEdgar MikeEdgar force-pushed the data-view-research branch 2 times, most recently from 8dee1e9 to 536444a Compare May 12, 2026 18:46
@MikeEdgar MikeEdgar marked this pull request as ready for review May 12, 2026 18:48
@MikeEdgar MikeEdgar force-pushed the data-view-research branch from 536444a to 50489c3 Compare May 13, 2026 11:26
@MikeEdgar MikeEdgar force-pushed the data-view-research branch from 50489c3 to d09b70b Compare May 15, 2026 12:38
alexcreasy
alexcreasy requested changes May 20, 2026
View reviewed changes

@alexcreasy alexcreasy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it's a really nice improvement, there's a couple of points I've raised - the one about ignoring the api error response is only potentially serious issue. The rest are just generally some small changes to promote best practice.

Comment thread api/src/main/webui/src/api/client.ts
Comment thread api/src/main/webui/src/api/types.ts Outdated
Comment thread api/src/main/webui/src/api/types.ts
Comment thread api/src/main/webui/src/components/common/ResourceListDataView.tsx
Comment thread api/src/main/webui/src/components/common/ResourceListDataView.tsx Outdated
Comment thread api/src/main/webui/src/components/common/ResourceListDataView.tsx Outdated
@MikeEdgar MikeEdgar force-pushed the data-view-research branch from d09b70b to 3be1148 Compare May 20, 2026 17:04
@MikeEdgar MikeEdgar requested a review from alexcreasy May 20, 2026 17:11
@MikeEdgar

MikeEdgar commented May 20, 2026

Copy link
Copy Markdown
Member Author

@alexcreasy I believe I've addressed your review comments, but let me know if something is still missing or out of place. The PR branch has been rebased, but the original commit is unchanged and your feedback is addressed in the second commit. Thanks!

@MikeEdgar MikeEdgar force-pushed the data-view-research branch from 3be1148 to 5b3a9f2 Compare May 26, 2026 12:57
@MikeEdgar

MikeEdgar commented May 26, 2026

Copy link
Copy Markdown
Member Author

After the update to PF 6.5 on main since the last rebase, this now appears to be blocked on patternfly/react-data-view#662.

MikeEdgar added 3 commits May 27, 2026 14:57
@MikeEdgar
Experiment with React data-view for Kafka clusters table
544c481 
Assisted-by: IBM Bob
Signed-off-by: Michael Edgar <medgar@redhat.com>
@MikeEdgar
Handle error via tanstack UseQueryResult, move hook, rename err obj
aad0889 
Signed-off-by: Michael Edgar <medgar@redhat.com>
@MikeEdgar
Work around patternfly/react-data-view regression
21d6ee2 
Signed-off-by: Michael Edgar <medgar@redhat.com>
@MikeEdgar MikeEdgar force-pushed the data-view-research branch from 5b3a9f2 to 21d6ee2 Compare May 27, 2026 20:29
@sonarqubecloud

sonarqubecloud Bot commented May 27, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@MikeEdgar MikeEdgar merged commit a6dc7b3 into streamshub:main May 27, 2026
8 checks passed
@MikeEdgar MikeEdgar deleted the data-view-research branch May 27, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexcreasy alexcreasy alexcreasy approved these changes

@jankalinic jankalinic jankalinic approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.13.0

Development

Successfully merging this pull request may close these issues.

3 participants

@MikeEdgar @alexcreasy @jankalinic